Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep for idr #4

Closed
wants to merge 21 commits into from
Closed

Prep for idr #4

wants to merge 21 commits into from

Conversation

jburel
Copy link
Member

@jburel jburel commented Jul 3, 2024

Review the instructions
Changes to personal build needs to be removed.
see ome/omero-ms-image-region#4

@khaledk2
Copy link
Collaborator

I think it failed because of the new build of the microservice, the service was unable to run with the following error :

" java.lang.UnsupportedClassVersionError: com/glencoesoftware/omero/ms/image/region/OmeroVertxLauncher has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0

@jburel
Copy link
Member Author

jburel commented Jul 16, 2024

The build is Java 11, Java 8 is used. We should align to Java 11 since the microservice is by default only tested using Java 11+

@khaledk2
Copy link
Collaborator

Yes, it is necessary to install Java 11 for molecule testing. In addition, there is an error on sha256 for the build.
I have created a branch based on this PR (https://github.com/khaledk2/ansible-role-omero-ms-image-region/tree/fix) and applied that and it has passed on:
https://github.com/khaledk2/ansible-role-omero-ms-image-region/actions/runs/9964537072

@jburel
Copy link
Member Author

jburel commented Jul 17, 2024

sha256 I forgot to update it after tagging see https://github.com/ome/omero-ms-image-region/releases/download/2024.07.16/SHASUMS
Since your build used Java 8, we now need to check the version on idr-testing

@khaledk2
Copy link
Collaborator

I have modified my local branch https://github.com/khaledk2/ansible-role-omero-ms-image-region/tree/fix and added all the supported Java versions.
I have used the new build on:
https://github.com/jburel/omero-ms-image-region/releases/tag/2024.07.17 from ome/omero-ms-image-region#5
I have added a new attribute java_version whose default value is 11.
test has passed on:
https://github.com/khaledk2/ansible-role-omero-ms-image-region/actions/runs/9996241247

@khaledk2
Copy link
Collaborator

khaledk2 commented Aug 14, 2024

A new microservice build is available so I have created a new branch (new_ms_release) based on this branch. It also contains a fix for re-install issues using a new MS build.

@khaledk2 khaledk2 mentioned this pull request Sep 5, 2024
@jburel jburel closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants